ClickInventoryEvent cancelling and it's inventory use

[vlamorsky]

SpongeAPI 7.1.0

When I try to close a player’s inventory using listener: ClickInventoryEvent

private void methodName(ClickInventoryEvent event, Player player) {
        ItemStackSnapshot itemStackSnapshot = event.getCursorTransaction().getDefault();
        event.setCancelled(true);

        if (ItemTypes.COAL.equals(itemStackSnapshot.getType())) {
            player.closeInventory();
        }
    }

I get a message:

[Server thread/WARN] [Sponge]: This player is currently modifying an open container. This action will be delayed.

But alright, this warning is described here:

Player#closeInventory() warns in console

I solved this question as follows
(no more warnings)

private void methodName(ClickInventoryEvent event, Player player) {
        ItemStackSnapshot itemStackSnapshot = event.getCursorTransaction().getDefault();
        event.setCancelled(true);

        if (ItemTypes.COAL.equals(itemStackSnapshot.getType())) {
            Task.builder()
                    .execute(() -> {
                        player.closeInventory();
                    })
                    .submit(plugin);
        }
}

but is this the most correct decision?

[Yeregorix]

I think delaying like you did is the correct solution.

[vlamorsky]

Okay, thanks.

I had a similar question,
maybe there are some suggestions, or I don’t understand something.

There is a problem like this:

Modify items in inventory

Sorry for late asking but i tryng to modify a item on player inventory using the RandomByte example and i modified to this: The even is ClickInventoryEvent and i tryng to modify an open custom inventory on click event, to change the lore of clicked item. for (Inventory slot:event.getTargetInventory().slots()){ if (slot.peek().isPresent()){ ItemStack itema = slot.poll().get();//remove the item if (itema.getItem().equals(item.getItem())){ slot.set(item);//set the itemslot brea…

Attempts to cancel the event fail:
(if I cancel the event correctly → event.setCancelled(true) )

Modify items in inventory

Most events are fired before the results of the action occur. In your case, you are changing the slot contents, then Sponge applies the changes from the event onto the inventory. Try cancelling the event so Sponge doesn’t make those changes.

private void onClickInventoryEvent(ClickInventoryEvent event, Player player) {
        ItemStackSnapshot itemStackSnapshot = event.getCursorTransaction().getDefault();
        event.setCancelled(true);

        DyeColor dyeColor = itemStackSnapshot.get(Keys.DYE_COLOR).orElse(DyeColors.BLACK);
        if (DyeColors.LIME.equals(dyeColor)) {
            if (tryToBuyItem(player)) {
event.getTargetInventory().query(QueryOperationTypes.INVENTORY_PROPERTY.of(SlotPos.of(2, 5)))
                        .set(ItemStack.builder()
                                .itemType(ItemTypes.STAINED_GLASS_PANE)
                                .add(Keys.DYE_COLOR, DyeColors.LIME)
                                .add(Keys.DISPLAY_NAME, textCreator.fromLegacy("&6Buy"))
                                .add(Keys.ITEM_LORE, Arrays.asList(
                                        textCreator.fromLegacy("&3Balance&8: &2" + balance))
                                .quantity(1)
                                .build());

            }
}

^ in this case, the item is not changed in the inventory

As in the case above, using the Task.Builder helps:
(but I don’t really like this solution)

private void onClickInventoryEvent(ClickInventoryEvent event, Player player) {
        ItemStackSnapshot itemStackSnapshot = event.getCursorTransaction().getDefault();
        event.setCancelled(true);

        DyeColor dyeColor = itemStackSnapshot.get(Keys.DYE_COLOR).orElse(DyeColors.BLACK);
        if (DyeColors.LIME.equals(dyeColor)) {
            if (tryToBuyItem(player)) {
                 Task.builder()
                        .execute(() -> event.getTargetInventory().query(QueryOperationTypes.INVENTORY_PROPERTY.of(SlotPos.of(2, 5)))
                                    .set(ItemStack.builder()
                                .itemType(ItemTypes.STAINED_GLASS_PANE)
                                .add(Keys.DYE_COLOR, DyeColors.LIME)
                                .add(Keys.DISPLAY_NAME, textCreator.fromLegacy("&6Buy"))
                                .add(Keys.ITEM_LORE, Arrays.asList(
                                        textCreator.fromLegacy("&3Balance&8: &2" + balance))
                                .quantity(1)
                                .build());
                        .submit(HMVote.getInstance());

            }
}

But @JBYoshi tells, that:
... Try cancelling the event so Sponge doesn’t make those changes.

what am I doing wrong?