Geting armor stands on server start

codeHusky · June 7, 2017, 3:47pm

My plugin likes to throw away it’s old armor stands and make new ones every time the server starts, but I’m having trouble getting a list of armor stands and being able to remove them selectively. I’m doing this inside of GameStartedEvent. The code for this is on GitHub for HuskyCrates inside the main class. Mind the mess

RandomByte · June 7, 2017, 6:37pm

github.com

codeHusky/HuskyCrates-Sponge/blob/fe2562aec44008af3abce39bd3fd9aa998d1317f/src/main/java/pw/codehusky/huskycrates/HuskyCrates.java#L228


}).submit(this);
if(forceStop) {
    //logger.error("Since a blacklisted mod is loaded, HuskyCrates will not start. Please check higher in your logs for the reasoning.");
    return;
}
Sponge.getScheduler().createTaskBuilder().execute(new Consumer<Task>() {
    @Override
    public void accept(Task task) {
        logger.info("Deleting existing armor stands...");
        for(World bit: Sponge.getServer().getWorlds()) {
            for (Entity ent : bit.getEntities()) {
                if (ent instanceof ArmorStand) {
                    ArmorStand arm = (ArmorStand) ent;
                    if (arm.getCreator().isPresent()) {
                        if (arm.getCreator().get().equals(UUID.fromString(armorStandIdentifier))) {
                            arm.remove();
                        }
                    }
                }
            }
        }

I don’t understand your problem, do these two if clauses always succeed and result in all ArmorStand being removed?

codeHusky · June 7, 2017, 8:53pm

The issue is that the armor stands don’t “exist” after the server has started.

dualspiral · June 7, 2017, 10:14pm

EntityUniverse#getEntities() can’t find what isn’t loaded - if the chunk that the armour stand is in is not loaded, then the armour stand itself won’t be obtainable. So, it might find things around spawn, but away from spawn, they won’t get found at all.

You might be better off using the SpawnEntityEvent.ChunkLoad event to do this, or one of the other entity construction events.

codeHusky · June 7, 2017, 10:15pm

Thanks for the tip spiral. I’ll give that a shot and see how my stuff turns out that way.

ryantheleach · June 8, 2017, 7:50am

removing old, and adding new on chunk loads, and removing on chunk unload is the way to go.

It’s such a common pattern I thought about making some generic collections classes that already had listeners, and could build the objects that needed to track entities.

codeHusky · June 8, 2017, 1:37pm

That would be nice. When I’m testing I usually unsafely kill my servers so generally I don’t test the chunk unloading. I’ll have to implement that.