Need Help Implenting Custom Data

Zirconium · January 22, 2016, 2:17pm

Got it working - mostly
The only issue is when the data is deserialized after restarting the server, which fails with this exception:

[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: org.spongepowered.api.util.persistence.InvalidDataException: Could not deserialize com.blocklaunch.blwarps.data.WarpData! Don't worry though, we'll try to deserialize the rest of the data.
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at org.spongepowered.common.data.util.DataUtil.deserializeManipulatorList(DataUtil.java:130)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.tileentity.TileEntity.readFromNbt(TileEntity.java:212)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.tileentity.TileEntity.onReadFromNBT(TileEntity.java:191)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.tileentity.TileEntity.func_145839_a(TileEntity.java:63)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.tileentity.TileEntitySign.func_145839_a(TileEntitySign.java:48)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.tileentity.TileEntity.func_145827_c(TileEntity.java:104)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.world.chunk.storage.AnvilChunkLoader.loadEntities(AnvilChunkLoader.java:500)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:41)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:344)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:109)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:84)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.server.MinecraftServer.prepareSpawnArea(MinecraftServer.java:606)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.server.MinecraftServer.func_71222_d(MinecraftServer.java:583)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.server.MinecraftServer.func_71247_a(MinecraftServer.java:449)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:254)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:441)
[09:08:35] [Server thread/INFO] [STDERR]: [org.spongepowered.common.data.util.DataUtil:deserializeManipulatorList:131]: 	at java.lang.Thread.run(Thread.java:745)
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: Caused by: java.lang.NullPointerException
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: 	at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:213)
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: 	at org.spongepowered.api.data.manipulator.mutable.common.AbstractSingleData.<init>(AbstractSingleData.java:59)
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: 	at com.blocklaunch.blwarps.data.WarpData.<init>(WarpData.java:17)
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: 	at com.blocklaunch.blwarps.data.WarpDataManipulatorBuilder.create(WarpDataManipulatorBuilder.java:34)
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: 	at com.blocklaunch.blwarps.data.WarpDataManipulatorBuilder.build(WarpDataManipulatorBuilder.java:22)
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: 	at org.spongepowered.common.data.util.DataUtil.deserializeManipulatorList(DataUtil.java:124)
[09:08:35] [Server thread/INFO] [STDERR]: [java.lang.Throwable:printStackTrace:634]: 	... 19 more

The latest version of my code

Thanks in advance

simon816 · January 22, 2016, 2:33pm

This field is null

github.com

RobertHerhold/BLWarps/blob/6886ded8d9acda855b86bb35ba7e42999bbd120d/src/main/java/com/blocklaunch/blwarps/data/WarpDataManipulatorBuilder.java#L15


import com.blocklaunch.blwarps.Warp;
import org.spongepowered.api.data.DataHolder;
import org.spongepowered.api.data.DataView;
import org.spongepowered.api.data.manipulator.DataManipulatorBuilder;
import org.spongepowered.api.util.persistence.InvalidDataException;
import java.util.Optional;
public class WarpDataManipulatorBuilder implements DataManipulatorBuilder<WarpData, ImmutableWarpData> {
    private Warp warp;
    @Override
    public Optional<WarpData> build(DataView container) throws InvalidDataException {
        if (!container.contains(WARP.getQuery())) {
            return Optional.empty();
        }
        WarpData warpData = create();
        warpData = warpData.set(Keys.WARP, container.getSerializable(Keys.WARP.getQuery(), Warp.class).get());
        return Optional.of(warpData);
    }

You shouldn’t be storing references to data objects in the builder.

See here you call create() but the warp field has not been set

github.com

RobertHerhold/BLWarps/blob/6886ded8d9acda855b86bb35ba7e42999bbd120d/src/main/java/com/blocklaunch/blwarps/data/WarpDataManipulatorBuilder.java#L22


public class WarpDataManipulatorBuilder implements DataManipulatorBuilder<WarpData, ImmutableWarpData> {
    private Warp warp;
    @Override
    public Optional<WarpData> build(DataView container) throws InvalidDataException {
        if (!container.contains(WARP.getQuery())) {
            return Optional.empty();
        }
        WarpData warpData = create();
        warpData = warpData.set(Keys.WARP, container.getSerializable(Keys.WARP.getQuery(), Warp.class).get());
        return Optional.of(warpData);
    }
    public WarpDataManipulatorBuilder setWarp(Warp warp) {
        this.warp = warp;
        return this;
    }
    @Override

Zirconium · January 22, 2016, 2:42pm

I figured that was the case, but how is the create method any use to me if I have no way of passing in a Warp to use in the WarpData constructor?

simon816 · January 22, 2016, 3:00pm

Typically you use some sort of default. As there is no such thing as a ‘default’ warp in this case you’ll have to create an invalid Warp and make sure it always gets replaced with a real data. Looks like you do this for Jackson, it’s basically the same idea.

github.com

RobertHerhold/BLWarps/blob/6886ded8d9acda855b86bb35ba7e42999bbd120d/src/main/java/com/blocklaunch/blwarps/Warp.java#L32


private Vector3d position; // serialize the double x,y,z rather than the
                           // Vector3d
private double x;
private double y;
private double z;
private List<String> groups;
// Empty constructor for Jackson
public Warp() {
}
public Warp(String name, String world, Vector3d position) {
    super(name, world);
    this.position = position;
    this.x = formatDouble(position.getX());
    this.y = formatDouble(position.getY());
    this.z = formatDouble(position.getZ());

TrenTech · January 22, 2016, 4:44pm

Random thought. If a plugin writes its own data to player, what happens if that plugin gets removed? Is the server going to throw deserialization errors every time a player joins?

gabizou · January 22, 2016, 5:12pm

Only the first time. There’s an issue discussing the ramifications of plugin custom data and where it is stored.