Changing: "Server is still starting" Message

PT400C · August 3, 2016, 4:22pm

Hey,

I have a problem with the changeing of messages again. Is it possible to change the: “Server is still starting” message?

Please help

PT400C

Bammerbom · August 3, 2016, 4:38pm

My first tought was listening to ClientConnectionEvent.Auth but doesn’t seem to fire when the server is starting.

The message is hardcoded so changing it with the api will be hard

github.com

MinecraftForge/MinecraftForge/blob/0f6b16cada5d77e094aa2eedbe2a556b76656997/src/main/java/net/minecraftforge/fml/common/FMLCommonHandler.java#L620


 * Also verifies the client has the FML marker.
 *
 * @param packet Handshake Packet
 * @param manager Network connection
 * @return True to allow connection, otherwise False.
 */
public boolean handleServerHandshake(C00Handshake packet, NetworkManager manager)
{
    if (!shouldAllowPlayerLogins())
    {
        TextComponentString text = new TextComponentString("Server is still starting! Please wait before reconnecting.");
        FMLLog.info("Disconnecting Player: " + text.getUnformattedText());
        manager.sendPacket(new SPacketDisconnect(text));
        manager.closeChannel(text);
        return false;
    }
    if (packet.getRequestedState() == EnumConnectionState.LOGIN && (!NetworkRegistry.INSTANCE.isVanillaAccepted(Side.CLIENT) && !packet.hasFMLMarker()))
    {
        manager.setConnectionState(EnumConnectionState.LOGIN);
        TextComponentString text = new TextComponentString("This server requires FML/Forge to be installed. Contact your server admin for more details.");

PT400C · August 3, 2016, 4:44pm

Is there really no way to change it? Maybe, with the ClientConnectionEvent.Login event?

Please help

PT400C

TrenTech · August 3, 2016, 5:10pm

Auth triggers before Login

VcSaJen · August 3, 2016, 5:14pm

Maybe with mixins?

TrenTech · August 3, 2016, 5:38pm

The thing is, how is a plugin suppose to change the server starting message…if the server is still starting? Plugins haven’t completed initialization yet.

bdubz4552 · August 4, 2016, 2:35am

I was prepared to write a wall of text but instead I’ll say this.

There’s some technical memory management shenanegans going on here and basically even if a plugin did load before the server, there would be nowhere for the plugin to “grab” or “swap” the string, because the string doesn’t appear to exist outside of that method’s stack frame.

PT400C · August 4, 2016, 7:16am

Okay. Thanks. I did’nt get that in mind

PT400C

ryantheleach · August 4, 2016, 8:22am

Except that plugins do start before the server… That’s why there are ServerStarting Events?

gravityfox · August 4, 2016, 8:35am

Mixins solve this issue. They have for a long time now.

RandomByte · August 4, 2016, 9:34am

Then there would be two mixins: One for Forge and another for vanilla.

bdubz4552 · August 4, 2016, 1:32pm

TIL what mixins do. So it would be feasible then, if someone was willing to put the time towards it?

gravityfox · August 5, 2016, 1:35pm

Normally, you can write a single minecraft mixin that would do it for both platforms. I don’t know about this case, but i don’t think you need two versions of the plugin.

Bammerbom · August 5, 2016, 2:52pm

I couldnt even find the string in spongevanilla, can anyone test what happens when you connect early on spongevanilla?

bdubz4552 · August 5, 2016, 3:01pm

I looked into it, and the string is generated by Forge and handed off to the vanilla NetworkManager class. Seems like its less of a Sponge issue and more of a Forge issue.