📡 Updatifier v1.4.0 ~ Easy to use update checking

Flibio · February 9, 2016, 2:26pm

I have a feeling the issue may be related to Sponge Vanilla. Is there any why you could test your current setup with SpongeForge?

I just tested with the latest SpongeForge (1143) and only Updatifier installed on the server. Everything worked with no errors.

Minecrell · February 9, 2016, 6:12pm

@Flibio
Unfortunately the problem is a rather general one with the way your plugin works. As long as no other plugin (or with SpongeVanilla: the plugin loader itself) is accessing any annotation via reflection on the plugin class your plugin will fail to load, because in that case it will try to load your annotation class before your plugin is loaded.

Therefore, the same problem can be reproduced on SpongeForge with one of these plugins:

gist.github.com

https://gist.github.com/Minecrell/05dbebea6b5d684c1139

TestPlugin.java

package org.spongepowered.mod;

import me.flibio.updatifier.Updatifier;
import org.spongepowered.api.plugin.Plugin;

@Plugin(id = "testplugin", name = "TestPlugin")
@Updatifier(repoOwner = "Minecrell", repoName = "ServerListPlus", version = "3.4")
public final class TestPlugin {

    private final String id;

This file has been truncated. show original

TestPlugin2.java

package org.spongepowered.mod;

import com.google.inject.Inject;
import me.flibio.updatifier.Updatifier;
import org.slf4j.Logger;
import org.spongepowered.api.event.Listener;
import org.spongepowered.api.event.game.state.GamePreInitializationEvent;
import org.spongepowered.api.plugin.Plugin;

import java.lang.annotation.Retention;

This file has been truncated. show original

Running any of these plugins on a SpongeForge servers results in the following similar crash report:

gist.github.com

https://gist.github.com/Minecrell/b5b3175245c09be9f643

gistfile1.txt

---- Minecraft Crash Report ----
// I let you down. Sorry :(

Time: 2/9/16 7:06 PM
Description: Exception in server tick loop

net.minecraftforge.fml.common.LoaderException: com.google.common.util.concurrent.ExecutionError: com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: me/flibio/updatifier/Updatifier
	at net.minecraftforge.fml.common.LoadController.transition(LoadController.java:162)
	at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:543)
	at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:87)

This file has been truncated. show original

The reason why this always happens on SpongeVanilla is that unlike SpongeForge, SpongeVanilla is currently loading the plugin metadata directly from the annotation using reflection. This might be replaced later on, but for now this would be a general problem, because your plugin can never load on SpongeVanilla, unless it is loaded before all other plugins.

liach · February 10, 2016, 3:23am

So is it possible to make plugins that use votifier ship the annotation class in its jar to fix this problem?

Edit: Might it relate to guice or do I need to implement the annotation?

Edit2: Is there any more issue with the plugin if you remove the Updatifier annotation?

Flibio · February 10, 2016, 4:45am

@Minecrell

Any ideas on a solution that work with the annotation?

@liach

I believe that if the annotation was removed, and Updatifier used a different method of getting plugin data, it would work.

Jeremiah_Summers · February 10, 2016, 5:47am

I have an Idea… put 01 in front of the jar name… Sponge loads mods alpha-numeric by file name… numbers first. It’s a quick fix until Sponge can fix that dependency handling thing… that’s going to become rather important as more plugins depend on each other.

[05:58:09 INFO]: SpongeVanilla
Minecraft: 1.8.9
SpongeAPI: 3.1.0-SNAPSHOT-648d95f
SpongeVanilla: 1.8.9-3.1.0-BETA-239

[05:58:34 INFO]: Plugins (17): Minecraft, SpongeVanilla, Blood Money, SpongeAPI, EntityDisguise, Polis, EssentialCmds, Total Economy, PermissionsEx, VotifierListener, Updatifier, ItemAuction, ServerListPlus, Project Portals, NuVotifier, AdminShop, Prism

Latest log with it loading…
http://paste.fedoraproject.org/320610/55083947

Minecrell · February 10, 2016, 7:09am

While that does indeed fix the issue currently, this is a temporary workaround this is going to be removed as soon as plugin dependencies are implemented.

@Flibio
Now that he mentioned that, one possible fix would be of course to simply have all plugins using Updatifier specify an optional dependency on it, so as soon as this is implemented in SV, it would always load Updatifier first, and therefore we wouldn’t have any problems with inexistent classes anymore.

Flibio · February 10, 2016, 2:50pm

That is one of the steps in adding Updatifier support to your plugin. You must add it as as an optional dependency.

dependencies = "after: Updatifier"

For now, I will add a note stating that Updatifier will not work with SpongeVanilla if it is not renamed and loaded first.

@Jeremiah_Summers

The latest log looks good, I don’t see any errors!

Jeremiah_Summers · February 10, 2016, 3:02pm

Yup that was my point… Im good for now with just renaming the jar file

Flibio · February 19, 2016, 3:11am

Updatifier v1.3.0 is now available!

Added commands to check updates from a player who has updatifier.notify permission, or the console
Added clickable links for players who get notified
Added an api jar which other plugins could ship and interact with Updatifer.
Note: To make Updatifer work on SpongeVanilla, the plugin that uses Updatifier must ship Updatifer api jar, which is available on jitpack maven. Documentation will come later.

Download Updatifier

Issues & Suggestions

Source Code

Wiki

Support Me

HassanS6000 · February 22, 2016, 1:39am

I am a bit confused. I ran both EconomyLite with Updatifier installed on my server, and it refused to start. Is this intended? Am I not meant to install Updatifier itself on the server?

Flibio · February 22, 2016, 1:40am

Yes, you are, do you have a log?

EDIT: Found the problem… fixing it right now. I accidentally shaded Updatifier into the JAR.

HassanS6000 · February 22, 2016, 3:27am

What is this caused by?

Flibio · February 22, 2016, 3:40am

One of the plugins using Updatifier forgot to follow the wiki and add Updatifier as an after dependency: dependencies = "after: Updatifier". I’ll investigate and try to figure out who it was.

TrenTech · February 23, 2016, 1:03am

I think I’m doing something wrong. After running some tests with PJP, I noticed that Updatifier is not detecting new updates. The git tag matches the plugin version as per your wiki, but the only time I’ve actually seen it work is last night when I accidentally created a git release with an invalid tag (tag "v0.9.38 should have been “0.8.38”). Can you review my git page please?

Flibio · February 23, 2016, 1:46am

It worked perfectly for me. I used Updatifier v1.3.0 and PJP v0.9.39. Updatifier detected an update was available.

TrenTech · February 23, 2016, 2:37am

Well that makes me feel better. Must be a local issue. Thanks

Flibio · February 24, 2016, 2:19am

Updatifier v1.3.1 is now available!

Bug fix

Download Updatifier

Issues & Suggestions

Source Code

Wiki

Support Me

RandomByte · March 11, 2016, 10:57pm

Are you updating to API version 4 soon? The dependency declaration in @Plugin(...) has changed. Is the version of this plugin “1.3.1” or “v1.3.1”?

Flibio · March 11, 2016, 11:18pm

The update should be coming soon. The version is simply 1.3.1.

Flibio · March 12, 2016, 3:17am

Updatifier v1.4.0 is now available!

Updated to Sponge API v4.0.0

Download Updatifier

Issues & Suggestions

Source Code

Wiki

Support Me