I really like this one, works perfectly out of the box.
Just one request: I’m writing a plugin that pays a wage every minute and the “deposited” messages get a bit spammy. Could you add an option to make transactions silent?
I will see what I can do, and will update it for the latest version of sponge when I release v1.1 (unless you still need it for sponge v4?)
Currently it PM’s only the user when any transaction is done (I think I made an event out if it…), but perhaps it could have a timeout and simply say the sum of the transactions every n seconds, or be disabled completely?
I want to stay up to date as well, so feel free to update
Maybe add a view PM modes: Any transaction, Commands only (should be possible if transaction source is no player if I understand the API correctly), Scheduled and Not at all. (Tho I don’t see a point in having it displayed every X minutes, but who knows, maybe someone got a use for that)
feedbackType: <all, local, timeout, none>
and feedbackTimeout: <seconds>?
Timeout would “time out” the response time from one reply to the next, and then tell the user the difference I guess. I don’t know though, it sounds dirty, because I personally would want to know what’s going on with my account at any time!
Maybe I could have transaction spam detection then? Or have an interface for plugins to mute themselves?
Or have an option in the config file to mute plugins but say things about it’s own dealings?
(I’ve also been meaning to implement a transaction log, but I think I’ll save that for v1.2)
That’s why I mentioned the “commands only type”, that mutes transactions issued by plugins.
The thing is, I’ll later have banker and shop NPCs to interact with, and for those I’ll have to PM the player myself (Bought 10 items x for y f$). I’m totally ok with the messages triggered by everything else like /pay .
And (If I can get the Scoreboard to work) I’d like to display the balance there as well
I decided just to do the verboseLogging option, as it seemed quite logical and easy to implement.
Turns out it’s not so… the way I previously had implemented it was just to attached the message to any transaction event. These events are called by Sponge itself, and not my plugin. So I decided to just add a parameter internal into the transaction-object, but then the problem was that I now need to duplicate most of the signatures of the EconomyService itself to support my interall callings…
tl;d;r it’s going to take a little while Anything else though you guys want me to implement for v1.1?
Firstly, let me say that I love the idea of your plugin, especially having multiple currencies. It’s so clever! Now, for the but. Firstly, I don’t see much documentation on how to create new currencies. Also, what about converting between these currencies and such? Then, there seems to be an issue with the file structure. When I go to /fe currency help and click on one of the links it pastes the command /fm instead of /fe. When I manually type /fe currency details, it says not enough arguments. It doesn’t recognize the default Fedorian currency. When I type /fe add Fedorian (or fedorians or currency:fedorians) it says no matching pattern.
I hate to bombard you with issues, as lots of these issues very well be the way I’m using the plugin. Thanks for the help, though!
Yeah, about that… . Here’s a wiki I just made to help out.
Haven’t made that happen yet. Do you think I should? I was more along the lines of thinking people could implement that in shops and such.
And ouch, thanks for letting me know about the /fm thingy. I am (somewhat) developing another plugin that uses that prefix, so… yeah I messed up there lol. I will make a hotfix soon
Cool, having a wiki is very helpful, especially the currency page. Now I can start to create currencies.
Personally, I think that you should include currency conversion so that players can set a currency’s value in relation to the default currency. Like Default (Fedorians) - > Rubles = 0.2, so 5 Rubles is equivalent to 1 Fedorian and 0.20 of a Fedorian is equal to 1 Ruble. A player could type a command /currency rates to see the currency’s values in proportion to the default rate set in the config and then decide to convert with /currency convert 100 Feds Rubles or they could click a sign that says:
[Convert] Fedorians to Rubles 0.2 (5 rubles for every fedorian, pulled from config info)
Then you could have a prompt that has the player type into chat how much money they’d like to convert?
I know it would be very important for my server as I plan on having different regions of the world using different currencies. I plan on creating currency conversion booths where players can convert their money by clicking on a sign or a trader or something. If you don’t plan on incorporating a feature like this, do you have any suggestions of how I could do so?
Can’t wait to see what’s in store
Thanks so much!!!
Hmm. I like the idea… but I’d rather it be in a separate plugin.
I am somewhat making a Market plugin that does this whole complicated thing with “transactions” and trading and all that weird stuff, but perhaps I could make a small plugin that just implements this for you? (And, maybe, the virtual-accounts / business accounts too, eh?)
It’ll take a couple weeks since school starts up for me this coming monday though.
That sounds great! Yeah, I’m back to school Monday too, so all this time this week I’ve spent playing with Sponge and trying to get a feel for developing–it all gets pushed aside
Glad you enjoy it I haven’t touched it for quite a while, nor have I worked on mistakenCynic’s project because school’s been crazy and there hasn’t been much demand.
If you need anything fixed make sure to let me know!
Anything else though you guys want me to implement for v1.1?
. Here’s a 
I haven’t touched it for quite a while, nor have I worked on mistakenCynic’s project because school’s been crazy and there hasn’t been much demand.