@Jinlin_Chen As far as deleting the shop you could break a hole in the wall, stand in it, and run the delete command, you could also delete the entry for the shop in the shops.config file in the playershopsrpg config directory.
Ah, forgot to add documentation. You specify an amount of money when renting the shop, you’ll then own the shop for the duration of time equal to the amount divided by the hourly rate, you can extend the rent in the same manner. Shop owners can change the rent price for future rents, change the shop owner, or destroy the shop while it’s being rented, assuming they have the proper command permissions of course. Everything else can only be changed by the person renting the shop for the duration of the rent.
Now, if I put something in the shop and I use “/shop destroy”, goods will not come back to my inventory. I am curious if the shop owner destroy the shop, can people who rent the shop take back their goods?
No, when you destroy the shop all the items are lost, this is because shops are able to contain many more items than would fit in a player’s inventory. If a shop owner destroys a shop while it is being rented, the person renting it will get nothing back. I could see potentially preventing shop owners from destroying shops while they are being rented, however I didn’t want to take that freedom away unnecessarily.
Right, but only the owner of the shop with a playershopsrpg.command.destroy permission, or non-owners with the previous permission and the playershopsrpg.bypass.owner permission can destroy shops. I could look into spawning the items on the ground, but if a shop contains hundreds of items that would get pretty laggy real fast. If you don’t trust shop owners to not destroy shops containing items simply don’t give them permission.
Hmmm, I suppose you have a point, I’ll look into having a force option in the next update and making the default behavior that the shop won’t be deleted. I think that’s a better way to handle it than trying to spawn all the items on the ground or partially filling the player’s inventory.
Very much appreciate the backports of this plugin for those of us on 1.8.9
One thing i noted in the previous version that i forgot to come mention. was if players didn’t have free inventory slots. they could still buy from the shop like normal and have money redacted, however would not see any items from the transaction. even if they then made space. not sure if the inventory API would be needed for monitoring that though.
I really appreciate all the work you put into this though, it’s definitely the best shop plugin on sponge so far!
Definitely! sorry it took me a while, i go back and forth between the sponge forums sometimes. i created an issue topic in the “issues” section of your git hub project for it.
Minecraft 1.10.2 - Tested on spongevanilla-1.10.2-5.1.0-BETA-366
Changes:
Changed config file extensions to .conf from .config to match convention. Important: Rename the extensions of your config files located in ~/config/playershopsrpg to transfer your data over!
Added messages.conf file to enable translating PlayerShopsRPG to multiple languages!
/shop destroy command will now warn you when destroying a shop containing items, you will have to use /shop destroy force if that is what you want to do.
Numerous bugfixes
Stable Release!
This release marks a large milestone for PlayerShopsRPG, it is now out of the pre-release phase!
Enjoy!
Minecraft 1.10.2 - Tested on spongevanilla-1.10.2-5.1.0-BETA-366
Changes:
Fixed NullPointerException when the player tries to sell more of an item than they have, to update delete your messages.conf file and let it regenerate.
Enjoy!
@anon34495435 Sorry about that, should be fixed now!
When you attempt to sell the item, you do have at least 1 in your inventory?
The buy behavior is not replicated when I test it, however I am testing on Minecraft 1.10.2, I suspect that changes in API 6.0 for Minecraft 1.11 are leading to the strange behavior. I’ll do some further testing later today to confirm.
