Inspector [v0.6.4] - Rollback, BlockTracking, and more!

CainSeldon · December 2, 2016, 10:50pm

Any updates on this plugin? I am really hoping this is being continued, as the bug where no region is able to be selected is still present.

AsyDRabbit · December 20, 2016, 5:01pm

Again, I believe he’s having some personal time.
Last I was aware of he’d been in hospital if I recall correctly.
Christmas also tends to be a busy time.

Not aimed at you specifically Shape, but the general grabby nature of comments on threads for free plugins that come at the cost of a lot of time and work for people is a little irksome.
Been digging through threads today so this is a bit of a vent in general but people need to be more appreciative u.u

For now it seems that @HassanS6000 is on a hiatus.
He last commented just under a month ago, but was last online a week ago.

It could just be that he has notifications off.

Rasgnarok · December 21, 2016, 6:02pm

‘Discontinued’ implies there is no plan for an improvement in the future (sometime between soon™ and soonish™). Hassan having last updated Inspector in… June 22nd, you can be assured that it is indeed outdated and therefore, will only work with Spongeforge builds around that time.

Considering that Spongeforge allows for build numbers, versioning, and has an impressive changelog, you, as a server admin, can always make an informed decision. The dates and record are there to show it. Inspector, as far as I have used, will not work with latest versions - and if it ever manages to boot up, you can rest assured it’ll have a negative impact on server performance. If you wanted to know, you could always test on your own test server.

Lastly, the responsibility for using plugins rests on the user, not the provider. Hassan’s plugins have served the Sponge community superbly (s/o to EssentialCmds), but an outdated plugin is an outdated plugin. And us server managers ought to know what it implies, when you are easily 2000 builds behind the latest stable Spongeforge for 1.10.2. This is not me telling you free=happy, this is me explaining that most of the time, with any modded community, chosing the plugin to use rests on the user. Give priority to plugins with active developers, with a responsive thread, and it’ll reward you much more than using a half-year old plugin (even when this fact is clearly indicated).

AsyDRabbit · December 22, 2016, 2:32am

And to add on to that - if you’re in a position to spend hundreds, with an active server, then engage a dev to do the work for you. There are enough floating around here.
I’ve pretty much kept my server alive over the past 3 years just to keep it as a hobby I can return to. I’m lucky enough that I have the spare capital that I can pay a few hundred a year to do this and pay developers to create content for what is essentially a cash-sink. You are in a far better position.
Yes it makes you incumbent to provide for your server, but that’s just it. You have to provide. Not Hassan. Not any other dev that posts for free. You.
Keep up to date. Keep on top. Seek out new alternatives and back-ups.

And … I specifically said that it wasn’t aimed at you but was a generic rant u.u

Nice to see the conscience at work there though

aso · January 6, 2017, 2:40am

Looks like primary plugin task work - it can tell what block was modified and by who. Region selection and rollback not working, but anyway, there is no plugin like this for Sponge, currently.

Only “small” problem is big spam in console: Could not pass InteractBlockEvent$Secondary$MainHand$Impl

Hassan, maybe you would take some time to fix only this error? IMHO, the most important function is block tracking, not rollback etc.

Rasgnarok · January 8, 2017, 6:08pm

I’d refer you to my reply above, where I explain that Hassan is on hiatus regarding this - and it would be quite disastrous to use this on spongeforge for API 5.1.0. Would not recommend its usage, no matter the scarcity of block-tracking plugins on Sponge.

HassanS6000 · January 8, 2017, 11:01pm

Release v0.6.4:

This only works for Sponge API 5.1.0

Changes:

Performance fixes - moved a few database calls to asnyc thread
Changes for new API version

Enjoy!

zsn741656478 · January 9, 2017, 5:55pm

Hello,I like this plugin very much.I want to share this plugin in MCBBS.Can you agree with me? www.mcbbs.net

HassanS6000 · January 10, 2017, 9:28pm

Yes you may share it there

zsn741656478 · January 11, 2017, 6:23am

OK.Thanks~

Magnus · January 14, 2017, 3:34pm

I’m getting an error that the PLAYERS table is missing, looking at the error it seems that the syntax is wrong (in the plugin?), this happens on a new install and I’ve tried making a new database for the plugin and it still happens. Only the BLOCKINFO table is created.

[16:27:09] [Server thread/INFO]: [STDERR]: java.sql.SQLSyntaxErrorException: (conn:44226) You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'NOT NULL, UUID          TEXT       NOT NULL, NAME          TEXT       NOT NULL)' at line 1
Query is : CREATE TABLE IF NOT EXISTS PLAYERS(ID INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, UUID          TEXT       NOT NULL, NAME          TEXT       NOT NULL)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.util.ExceptionMapper.get(ExceptionMapper.java:134)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.util.ExceptionMapper.getException(ExceptionMapper.java:101)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.util.ExceptionMapper.throwAndLogException(ExceptionMapper.java:77)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeQueryEpilog(MariaDbStatement.java:224)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeInternal(MariaDbStatement.java:258)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeUpdate(MariaDbStatement.java:387)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at com.zaxxer.hikari.pool.ProxyStatement.executeUpdate(ProxyStatement.java:120)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at com.zaxxer.hikari.pool.HikariProxyStatement.executeUpdate(HikariProxyStatement.java)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at io.github.hsyyid.inspector.utilities.DatabaseManager.isPlayerInDatabase(DatabaseManager.java:130)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at io.github.hsyyid.inspector.listeners.PlayerJoinListener.onPlayerJoin(PlayerJoinListener.java:12)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.spongepowered.common.event.listener.JoinListener_PlayerJoinListener_onPlayerJoin85.handle(Unknown Source)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:301)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:285)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:326)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:314)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:144)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraft.server.management.PlayerList.initializeConnectionToPlayer(PlayerList.java:1616)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.completeServerSideConnection(NetworkDispatcher.java:262)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.access$100(NetworkDispatcher.java:73)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:211)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:287)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:743)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:384)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at java.lang.Thread.run(Thread.java:745)
[16:27:09] [Server thread/INFO]: [STDERR]: Caused by: org.mariadb.jdbc.internal.util.dao.QueryException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'NOT NULL, UUID          TEXT       NOT NULL, NAME          TEXT       NOT NULL)' at line 1
Query is : CREATE TABLE IF NOT EXISTS PLAYERS(ID INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, UUID          TEXT       NOT NULL, NAME          TEXT       NOT NULL)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.protocol.AbstractQueryProtocol.getResult(AbstractQueryProtocol.java:1114)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.protocol.AbstractQueryProtocol.executeQuery(AbstractQueryProtocol.java:137)
[16:27:09] [Server thread/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeInternal(MariaDbStatement.java:249)
[16:27:09] [Server thread/INFO]: [STDERR]: 	... 23 more
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: java.sql.SQLSyntaxErrorException: (conn:44226) Table 'Inspector.PLAYERS' doesn't exist
Query is : INSERT INTO PLAYERS (UUID, NAME) VALUES ('110e29ea-3593-42e7-a91c-83f077229d42','kattusb');
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.util.ExceptionMapper.get(ExceptionMapper.java:134)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.util.ExceptionMapper.getException(ExceptionMapper.java:101)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.util.ExceptionMapper.throwAndLogException(ExceptionMapper.java:77)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeQueryEpilog(MariaDbStatement.java:224)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeInternal(MariaDbStatement.java:258)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeUpdate(MariaDbStatement.java:387)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at com.zaxxer.hikari.pool.ProxyStatement.executeUpdate(ProxyStatement.java:120)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at com.zaxxer.hikari.pool.HikariProxyStatement.executeUpdate(HikariProxyStatement.java)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at io.github.hsyyid.inspector.utilities.DatabaseManager.lambda$addPlayerToDatabase$1(DatabaseManager.java:111)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.spongepowered.api.scheduler.Task$Builder.lambda$execute$0(Task.java:138)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.spongepowered.common.scheduler.SchedulerBase.lambda$startTask$0(SchedulerBase.java:183)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at java.lang.Thread.run(Thread.java:745)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: Caused by: org.mariadb.jdbc.internal.util.dao.QueryException: Table 'Inspector.PLAYERS' doesn't exist
Query is : INSERT INTO PLAYERS (UUID, NAME) VALUES ('110e29ea-3593-42e7-a91c-83f077229d42','kattusb');
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.protocol.AbstractQueryProtocol.getResult(AbstractQueryProtocol.java:1114)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.internal.protocol.AbstractQueryProtocol.executeQuery(AbstractQueryProtocol.java:137)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	at org.mariadb.jdbc.MariaDbStatement.executeInternal(MariaDbStatement.java:249)
[16:27:09] [pool-3-thread-3/INFO]: [STDERR]: 	... 11 more

config:
database { mysql { database=Inspector enabled=true host=localhost password=[password] port="3306" username=minecraft } } inspector { select { tool="minecraft:diamond_hoe" } }

11115 · March 6, 2017, 1:57pm

error in spongeforge-1.10.2-2202-5.1.0-BETA-2099
Error occurred while executing command ‘insp’ for source EntityPlayerMP

Link error code : http://pastebin.com/zQUCRJnE

11115 · March 7, 2017, 2:01am

fix error post from

11115 · March 10, 2017, 4:57pm

Can not check before block to air but block to block can check normally.

HassanS6000 · March 23, 2017, 9:51pm

Important Notice to Inspector Users

After reviewing the plugin recently I have found numerous bugs and a lack of features, and am currently working on rewriting most of the plugin to work with more use cases (ie. checking chests) and be more efficient.

TomberWolf · March 23, 2017, 10:23pm

This looks promising!

Does it wirk with mod items?
What if a player uses a magic tool or a stationary laser cannon from a mod for example?

HassanS6000 · March 25, 2017, 1:49pm

It should track modded items, and if the mod extends base MC code, it should work with it too

11115 · March 26, 2017, 12:23am

Wait update fix bug and lack.

sklm · March 31, 2017, 10:16am

Will it be updated?
It now has a fatal problem.
Will lead to collapse!
I think it is a database problem!

Rasgnarok · March 31, 2017, 4:43pm

If you have found a bug, please submit a detailed account to Inspector’s tracker: Issues · hsyyid/Inspector · GitHub